Re: Export get_sb_pseudo()?

[Christoph Hellwig]

On Sat, Jan 08, 2005 at 07:31:01PM +0000, Al Viro wrote:
> On Sat, Jan 08, 2005 at 10:40:10AM -0800, Roland Dreier wrote:
> > I'm planning on implementing some modular driver code and I think it
> > makes sense to have a non-mountable pseudofs.  Especially with the
> > recent MVFS controversy, it seems prudent to find out whether this
> > usage would merit exporting get_sb_pseudo(), so I'll describe my
> > current plans below.
> 
> No objections; it certainly falls under "general-purpose library
> helper".  Moreover, in this case I _insist_ on use of normal
> export; it is a convenience helper that
> 	a) can be trivially reimplemented by anyone who cares; any
> number of filesystems is open-coding far more than that in their
> ->get_sb(), so there's nothing to protect here.
> 	b) can be trivially simulated by simple_fill_super() followed
> by a bit of tweaking the result.
> 	c) does not shove any pitchforks into the kernel guts - resulting
> superblock does not require any special treatment.

Agreed.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/