Re: PATCH: 2.6.10 - IT8212 IDE

[Bartlomiej Zolnierkiewicz]

On Wed, 29 Dec 2004 21:24:45 +0000, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mer, 2004-12-29 at 17:29, Bartlomiej Zolnierkiewicz wrote:
> > ide_get_best_pio_mode(drive, 4, 5, NULL) always returns 4
> > [ quick fix == hardcode 4 for now and add FIXME ]
> 
> Doesn't seem that way reading the code.

u8 ide_get_best_pio_mode (ide_drive_t *drive, u8 mode_wanted, u8
max_mode, ide_pio_data_t *d)
{

/* mode_wanted == 4, max_mode == 5 */

...

	if (mode_wanted != 255) {

/* 4 != 255 */

		pio_mode = mode_wanted;

/* pio_mode == 4 */

	} else if (!drive->id) {
		pio_mode = 0;
	} else if ((pio_mode = ide_scan_pio_blacklist(id->model)) != -1) {
		overridden = 1;
		blacklisted = 1;
		use_iordy = (pio_mode > 2);
	} else {
...
	}
...
	return pio_mode;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/