Re: [ckrm-tech] [PATCH] CKRM: 6/10 CKRM: Resource controller forsockets

[James Morris]

On Mon, 29 Nov 2004, Gerrit Huizenga wrote:


> Index: linux-2.6.10-rc2-ckrm1/include/net/sock.h
> ===================================================================
> --- linux-2.6.10-rc2-ckrm1.orig/include/net/sock.h	2004-11-14 17:28:14.000000000 -0800
> +++ linux-2.6.10-rc2-ckrm1/include/net/sock.h	2004-11-24 12:33:23.000000000 -0800
> @@ -249,6 +249,7 @@
>  	struct timeval		sk_stamp;
>  	struct socket		*sk_socket;
>  	void			*sk_user_data;
> +	void			*sk_ns; // For use by CKRM
>  	struct module		*sk_owner;
>  	struct page		*sk_sndmsg_page;
>  	__u32			sk_sndmsg_off;
> 

Why is this a void pointer?  Seems like it is only ever used for struct
ckrm_net_struct.  Also, please call it something obviously ckrm related
and it won't need the comment. (And why put the comment there anyway when
the other fields are documented in a comment block above?)


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/