Re: Any reason why we don't initialize all members of structXgt_desc_struct in doublefault.c ?

[Zwane Mwaikambo]

On Thu, 25 Nov 2004, Jesper Juhl wrote:

> Yes, this is nitpicking, but I just can't leave small corners like this 
> unpolished ;)
> 
> in arch/i386/kernel/doublefault.c you will find this (line 20) :
> 
> struct Xgt_desc_struct gdt_desc = {0, 0};
> 
> but, struct Xgt_desc_struct has 3 members, 
> 
> struct Xgt_desc_struct {
>         unsigned short size;
>         unsigned long address __attribute__((packed));
>         unsigned short pad;
> } __attribute__ ((packed));
> 
> so why only initialize two of them explicitly?
> 
> 
> Wouldn't this be nicer? :

I can't see what the point is, it's a machine defined struct which only 
uses the first 6bytes. It'll never bother with the pad variable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/