Re: scheduler BUGON lifespan

From: Ingo Molnar
Date: Mon Nov 29 2004 - 17:43:40 EST



* Darren Hart <dvhltc@xxxxxxxxxx> wrote:

> I submitted a patch to active_load_balance() that was accepted into mm
> and then mainline. The patch included a fix to prevent the system
> entering what should have been an impossible state. The previous code
> tested for it and then continued, rather than crashing or complaining.
> My patch added a BUGON(impossible state) just in case by some fluke it
> still happened. How long should this BUGON remain in the kernel? A
> month, a year? Is there an accepted duration for such safety nets?

it's pretty random how long it survives. Sometimes i remove one after
never having seen it for months/years and grepping lkml and googling
around for the file & line. The BUG_ON()s are pretty cheap, as they
often check what is being fetched anyway.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/