Re: [PATCH] CKRM 1/10: Base CKRM Events

From: Dave Hansen
Date: Mon Nov 29 2004 - 15:38:49 EST


On Mon, 2004-11-29 at 10:46, Gerrit Huizenga wrote:
> +#define CKRM_DEF_CB(EV,fct) \
> +static inline void ckrm_cb_##fct(void) \
> +{ \
> + ckrm_invoke_event_cb_chain(CKRM_EVENT_##EV,NULL); \
> +}

The sysfs code has a bunch of these, and I think it's one of the hardest
to follow and least palatable parts of working with it. It makes
finding real declarations hard, and can make debugging a pain if
something goes wrong. You get an error in ckrm_cb_FOO(), cscope or grep
for 'ckrm_cb_FOO' and scratch your head when you come up with squat.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/