Re: Problem with ioctl command TCGETS

From: Miklos Szeredi
Date: Sun Nov 28 2004 - 05:20:20 EST


> The idea is nice, yet the "dir" and "size" parameters in the original _IO*
> macros are only there (IMO) to protect against using the wrong value for the
> wrong operation on the wrong fd/file/device/socket/etc.

Size and dir are there to make the memory passed to the syscall easily
verifiable (like read/write/getsockopt/setsockopt/etc)

> What is the point in making "param" a char*? You would need to parse it down
> again.

'char *' namespace is easier to manage than 'int' namespace.

> Oh yeah and call it ioctl2(), sounds more cryptical :)

Is that an advantage?

Thanks,
Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/