Re: [linux-usb-devel] [PATCH] Ohci-hcd: fix endless loop

From: David Brownell
Date: Sat Nov 27 2004 - 01:51:35 EST


On Friday 26 November 2004 08:54, Colin Leroy wrote:
> On 26 Nov 2004 at 08h11, David Brownell wrote:
>
> Hi,
>
> > The infinite loop means that something trashed the stack, yes?
> >
> > The "limit-- < -1000" test below should never be able to succeed
> > unless the previous "limit-- == 0" test got trashed by having
> > something obliterate the stack.
>
> Sure? the (limit -- == 0) gotoes higher to test again.
> from what I understand the loop goes back to rescan 1000 times, then once
> to sanitize, then to back to rescan again infinetely...
> I may be wrong but I don't think there's a stack corruption there.

The "limit" isn't tested a 1001st time, since the ED state
changed.

For that matter, any time that the IRQ lossage appears,
there's always been something that damaged the IRQ setup.

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/