Re: [PATCH] smsc-ircc2: Add PnP support.

From: matthieu castet
Date: Fri Nov 26 2004 - 23:36:35 EST


Meelis Roos wrote:
Could you please attach the output of 'cat 00:0a/resources' (0a is the
device, right?). ACPI spec said set resource should be according to the
output of current resource. That is we should build a template according
to current resource (_CRS). If _CRS doesn't return a correct resource
templete, set resource will fail.


Hi,

could you try this patch with the previous one. (You must enable ACPI DEBUG in kernel config)

When you activate the device, it sould print usefull information.
Could attach the output, please.

Matthieu --- linux-2.6.9/drivers/pnp/pnpacpi/rsparser.c.old 2004-11-12 22:55:10.000000000 +0100
+++ linux-2.6.9/drivers/pnp/pnpacpi/rsparser.c 2004-11-26 16:33:42.000000000 +0100
@@ -29,6 +29,18 @@
#define valid_IRQ(i) (((i) != 0) && ((i) != 2))
#endif

+static void debug_pnp(struct acpi_resource *res, int line) {
+ int tmp = acpi_dbg_level;
+ int tmp1 = acpi_dbg_layer;
+
+ acpi_dbg_level = 0x00010000;
+ acpi_dbg_layer = 0x00000100;
+ printk("******%d*******\n",line);
+ ACPI_DUMP_RESOURCE_LIST(res);
+ acpi_dbg_level = tmp;
+ acpi_dbg_layer = tmp1;
+}
+
/*
* Allocated Resources
*/
@@ -152,6 +164,8 @@
{
struct pnp_resource_table * res_table = (struct pnp_resource_table *)data;

+ debug_pnp(res,__LINE__);
+
switch (res->id) {
case ACPI_RSTYPE_IRQ:
if ((res->data.irq.number_of_interrupts > 0) &&
@@ -454,6 +469,8 @@
struct pnp_dev *dev = parse_data->dev;
struct pnp_option *option = parse_data->option;

+ debug_pnp(res,__LINE__);
+
switch (res->id) {
case ACPI_RSTYPE_IRQ:
pnpacpi_parse_irq_option(option, &res->data.irq);
@@ -816,5 +843,7 @@
resource ++;
i ++;
}
+ debug_pnp(res,__LINE__);
+
return 0;
}