Re: [linux-pm] [PATCH] make pm_suspend_disk suspend/resume sysdev and dpm_off_irq

[Pavel Machek]

Hi!

> >> This patch makes the new swsusp code ( pm_suspend_disk since
> >> 2.6.9-rc3) call suspend/resume functions for sysdev and devices in
> >> dpm_off_irq list. Otherwise, PCI link device in the system won't
> >> provide correct interrupt for PCI devices during resume.
> > 
> > I do not think this is right approach; you enable interrupts
> > then disable that again, potentially without interrupt controller
> > being initialized. 
> > 
> > This should be better patch:
> 
> Agreed. Your patch solves the bug. But do you plan to deal with the 
> devices in dpm_off_irq list?

Ouch, okay... Calling irq-off phase of device_suspend() is not
intuitive at all and I hate that -EAGAIN idea.

...ouch, wait, it is less messy than I expected. I have no business
calling sysdev_suspend directly.

I'll test the patch and post it in the next message.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/