Re: adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, patch to Kconfig, and patch to Makefile) [fixed]

From: Greg KH
Date: Wed Nov 24 2004 - 19:11:18 EST


On Wed, Nov 24, 2004 at 03:10:17PM -0800, Justin Thiessen wrote:
> On Wed, Nov 24, 2004 at 01:36:00PM -0800, Greg KH wrote:
> > Hm, this looks like a bug:
>
> <snip egregious stupidity>
>
> > Care to fix this up and resend the whole patch?
>
> Affirmative.
>
> > Oh, and it should be "Signed-off-by:" not "Signed off by:" like you had
> > used :)
>
> See below:

Applied, thanks.

Oh, I did make one change:

> +/* Adjust fan_min to account for new fan divisor */
> +void fixup_fan_min(struct device *dev, int fan, int old_div)

This should be static.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/