Re: [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet Administration)query support

[Roland Dreier]

    Greg> Please hack your submit script to not add these headers,
    Greg> when importing to bk they end up showing up in the change
    Greg> log comments :(

OK, will do.

    Greg> No email address of who to bug with issues?

There's a patch to MAINTAINERS...

    Greg> Why is this packed?
    Greg> Same here?

Both of these structures unfortunately have 64 bit fields only aligned
to 32 bits (and are sent on the wire so we can't fiddle with the
layout).  So without the "packed" they won't come out right on 64-bit archs.

    Greg> Should this be global or static?

static, fixed.

    Greg> Oops, tabs vs. spaces.

fixed.

    Greg> Care to use the __bitwise field here so that you can have
    Greg> sparse check to see that you are actually using the proper
    Greg> enum values in all places?  See the kobject_action code for
    Greg> an example of this.

Sure, that's a good idea.  I'll look for other places we can do this too.

    Greg> What is "RESERVED"?  I must be missing a previous patch
    Greg> somewhere, I currently don't see all of the series yet.

It's in part 1/12: http://article.gmane.org/gmane.linux.kernel/257531
unfortunately some people marked it as spam and it didn't get
everywhere.

 - Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/