Re: modprobe + request_module() deadlock

From: Gerd Knorr
Date: Mon Nov 22 2004 - 12:11:55 EST


> > I can fix that in the driver, by delaying the request_module() somehow
> > until the saa7134 module initialization is finished. I don't think that
> > this is a good idea through as it looks like I'm not the only one with
> > that problem ...
>
> Delaying request_module() sounds ugly. Anyway, if you can
> get it to work reliably...

I think I can, havn't tried yet through.

> Actually dvb-bt8xx.ko has a similar problem (no hotplug for DVB). It
> uses bttv_sub_register(), though, but this doesn't do probing
> and the PCI ids have to be in bttv-cards.c. It would be nicer
> if dvb-bt8xx.ko could use a similar mechanism as dvb-ttpci.ko.

Well, you can use the second PCI function.

> Or do you plan to add request_module("dvb-bt8xx") in bttv-driver.c?

I can do that as well, bttv knows anyway which ones are dvb cards and
which ones are not.

> And how about cx88 (I haven't checked this)?

cx88-dvb has a PCI ID table. The cx2388x has a separate PCI function
for the MPEG stuff which makes it a bit easier to get that handled
by hotplug directly ;)

Gerd

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/