Re: [RFC][PATCH] problem of cont_prepare_write()

From: OGAWA Hirofumi
Date: Mon Nov 22 2004 - 06:43:11 EST


Andrew Morton <akpm@xxxxxxxx> writes:

> Perhaps cont_prepare_write() should look to see if the zerofilled page is
> outside the current i_size and if so, advance i_size to the end of the
> zerofilled page prior to releasing the page lock.

Yes, my first patch was it.

Umm... however, if ->i_size is updated before ->commit_write(),
doesn't it allow access to those pages, before all write() work is
successful?

Doesn't this cause strange behavior?
(especially a failure case of prepare_write())
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/