Re: [2.6 patch] misc ISAPNP cleanups

From: Adrian Bunk
Date: Sun Nov 21 2004 - 10:20:29 EST


On Tue, Nov 16, 2004 at 12:03:16AM -0500, Adam Belay wrote:
> On Sat, Nov 13, 2004 at 04:02:34AM +0100, Adrian Bunk wrote:
> > The patch below removes some completely unused code and makes some
> > needlessly global code static in drivers/pnp/isapnp/core.c .
> >
> > Please review whether this patch is correct or whether it conflicts with
> > pending ISAPNP updates/usages.
> >
> >
> > diffstat output:
> > drivers/pnp/isapnp/core.c | 47 ++++++++------------------------------
> > include/linux/isapnp.h | 20 ----------------
> > 2 files changed, 11 insertions(+), 56 deletions(-)
> >
> >
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> >
>
> I have to check that this doesn't break any obscure isapnp drivers. Otherwise

Why are these "obscure isapnp drivers" not included in the kernel?

> it looks good. Some of them, like "isapnp_alloc", look obvious.
>
> Thanks,
> Adam

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/