Re: [6/7] Xen VMM patch set : add alloc_skb_from_cache

[Keir Fraser]

> On Fri, Nov 19, 2004 at 09:11:04PM -0500, James Morris wrote:
> 
> > Most of this is duplicated code with alloc_skb(), perhaps make a
> > function:
> >
> >   __alloc_skb(size, gfp_mask, alloc_func)
> >
> > Then alloc_skb() and alloc_skb_from_cache() can just be wrappers
> > which pass in different alloc_funcs.  I'm not sure what peformance
> > impact this might have though.
> 
> I wonder if this would have a measurable performance hit on some
> platforms where the additional call/indirection could hurt?

Could make __alloc_skb 'static inline'?

 -- Keir
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/