Re: [PATCH] usb-storage should enable scsi disk in Kconfig

[Stelian Pop]

On Fri, Nov 19, 2004 at 07:57:36PM +0000, Christoph Hellwig wrote:

> On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote:
> > As $subject says, usb-storage storage should automatically enable
> > scsi disk support in Kconfig.
> > 
> > Please apply.
> 
> No, it shouldn't.  There's lots of usb storage devices that don't use
> sd, as there are lots of SPI/FC/etc.. devices.

Indeed, I should have checked more carefully. My bad.

Still, it is not obvious that one should go into a completly different
config section and manually enable sd support, and I have been bitten
by this more than one time.

Maybe we should add, just below the 'USB storage' Kconfig option another
one, let's say 'SCSI disk based USB storage support', which documentation
would talk about 'usb keys, memory stick readers, USB floppy drives etc',
which should just be a dummy option selecting  BLK_DEV_SD ?

Or perhaps we should add something along the Debian's dpkg 'suggests' rule
to Kconfig ? :)

Stelian.
-- 
Stelian Pop <stelian@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/