Re: [patch] 2.6.10-rc2-mm2: MTD_XIP dependencies

[Nicolas Pitre]

On Fri, 19 Nov 2004, Adrian Bunk wrote:

> On Thu, Nov 18, 2004 at 08:58:26PM -0500, Nicolas Pitre wrote:
> > On Fri, 19 Nov 2004, Adrian Bunk wrote:
> > 
> > > The #error should either go or be the same than the Kconfig dependency.
> > 
> > And on what basis?  This just doesn't make sense.
> > 
> > CONFIG_MTD_XIP is there to be compatible with kernels which are made 
> > XIP.  This currently means _all_ ARM flavours the kernel currently 
> > supports.  Yet there is only SA11x0 and PXA2xx which have proper MTD_XIP 
> > primitives ence the #error.
> > 
> > My position is therefore that the CONFIG_MTD_XIP should depend on 
> > CONFIG_XIP_KERNEL since this is what it is for, and the #error stay as 
> > is.  If ever you make x86 kernel XIPable you'll need to add the missing 
> > bits guarded by the #error anyway.
> > 
> > And no, allyesconfig makes little sense on ARM as it has been discussed 
> > on lkml before.
> 
> I'm not talking about allyesconfig.
> 
> The Kconfig file should express all dependencies of a driver.
> If a driver doesn't compile, it should not be selectable - and not 
> #error at compile time.

Absolutely!

So please would you just ask Andrew to apply the following patch and be 
happy?  Thank you.

--- ./drivers/mtd/chips/Kconfig.orig	Fri Nov 19 11:25:45 2004
+++ ./drivers/mtd/chips/Kconfig	Fri Nov 19 11:28:08 2004
@@ -274,8 +274,7 @@
 
 config MTD_XIP
 	bool "XIP aware MTD support"
-	depends on !SMP && MTD_CFI_INTELEXT && EXPERIMENTAL
-	default y if XIP_KERNEL
+	depends on XIP_KERNEL && !SMP && MTD_CFI_INTELEXT && EXPERIMENTAL
 	help
 	  This allows MTD support to work with flash memory which is also
 	  used for XIP purposes.  If you're not sure what this is all about


Nicolas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/