Re: [patch 2] Xen core patch : arch_free_page return value

From: Jeff Dike
Date: Wed Nov 17 2004 - 23:41:57 EST


akpm@xxxxxxxx said:
> But heck - why bother? The current patch adds just one line of code
> in one place, and the compiler will toss it away anyway for all but
> xen and um.

Agree, but on a conceptual level, this is allowing the arch to swipe pages
arbitrarily out from under the nose of the generic page allocator. Plus, the
code that's being bypassed has to be implemented in some form in the arch.
That's not my concern, or yours, necessarily, but it does suggest that the
interface is being abused.

Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/