Re: [PATCH] cx88: fix printk arg. type

[Andrew Morton]

"Randy.Dunlap" <rddunlap@xxxxxxxx> wrote:
>
> Gerd Knorr wrote:
>  >>-		dprintk(0, "ERROR: Firmware size mismatch (have %ld, expected %d)\n",
>  >>+		dprintk(0, "ERROR: Firmware size mismatch (have %Zd, expected %d)\n",
>  > 
>  > 
>  > Thanks, merged to cvs.  I like that 'Z'.  Or is that just a linux-kernel
>  > printk specific thingy?  Or is this standardized somewhere?  So I could
>  > use that in userspace code as well maybe?
> 
>  Kernel supports/allows 'Z' or 'z'.
>  C99 spec defines 'z' only as a size_t format length modifier:
> 
>  z   Specifies that a following d, i, o, u, x, or X conversion 
>  specifier applies to a size_t or the corresponding signed integer type 
>  argument; or that a following n conversion specifier applies to a 
>  pointer to a signed integer type corresponding to size_t argument.
> 
>  Anyway, I agree with Al.  Will you please change it to
>  'z' instead of 'Z'?

gcc-2.95.x generates warnings for `z', but is happy with 'Z'.

But I seem to be the only person who uses 2.95, and I patched my version to
stop that warning anyway, so...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/