Re: [PATCH] Switch therm_adt746x to new module_param

From: Randy.Dunlap
Date: Wed Nov 17 2004 - 14:05:41 EST


Colin Leroy wrote:
Hi Andrew,

this patch replaces MODULE_PARM to module_param for adt746x.

Signed-off-by: Colin Leroy <colin@xxxxxxxxxx>
--- a/drivers/macintosh/therm_adt746x.c 2004-11-17 19:26:16.908413504 +0100
+++ b/drivers/macintosh/therm_adt746x.c 2004-11-17 19:28:01.193559752 +0100

@@ -56,11 +57,11 @@
"Powerbook G4 Alu");
MODULE_LICENSE("GPL");
-MODULE_PARM(limit_adjust,"i");
+module_param(limit_adjust, int, 0);
MODULE_PARM_DESC(limit_adjust,"Adjust maximum temperatures (50 cpu, 70 gpu) "
"by N degrees.");
-MODULE_PARM(fan_speed,"i");
+module_param(fan_speed, int, 64);

The last parameter here (64) is not an init. value nor a
suggested parameter value.
It's a permission for an entry in /sys (sysfs).
0 means not visible there.
If it should be visible there, use something like
0444 (read-only by anyone) or 0644 (read-write by root).

MODULE_PARM_DESC(fan_speed,"Specify starting fan speed (0-255) "
"(default 64)");



--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/