Re: [PATCH 3/3] raw1394: sysfs support via class_simple

[Daniel Drake]

Dmitry Torokhov wrote:
> Hmm, with the exception of raw1394, the rest of ieee1394 subsystem does
> not need its own classes as 1394 devices hook up into other subsystems
> (SCSI, NET) and are classified with the rest of the devices in those
> systems. After all userspace does not really care whether eth0 is on
> PCI, ISA or IEEE1394, all it needs to know that it is just another network
> interface. Am I missing something?

No, I think I was. I was trying to follow the way that USB does it (e.g. usblp 
linking into the usb sysfs class) but I think you are right - IEEE1394 is in a 
different situation. raw1394 is the only ieee1394 driver (as far as I can see) 
that might benefit fitting into a generic class. I think we should stick with 
class_simple and possibly consider a generic class if more drivers might 
require it in the future.

Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/