Re: [PATCH 475] HP300 LANCE

[Andrew Morton]

Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> > There's tons of leaks in the hplcance probing code, and it doesn't release
>  > he memory region on removal either.
>  > 
>  > Untested patch to fix those issues below:
> 
>  ping.

The fix needs a fix:


diff -puN drivers/net/hplance.c~hp300-lance-leak-fixes-fix drivers/net/hplance.c
--- 25/drivers/net/hplance.c~hp300-lance-leak-fixes-fix	2004-11-16 23:11:46.546476832 -0800
+++ 25-akpm/drivers/net/hplance.c	2004-11-16 23:12:00.027427416 -0800
@@ -96,7 +96,7 @@ static int __devinit hplance_init_one(st
 	hplance_init(dev, d);
 	err = register_netdev(dev);
 	if (err)
-		goto out_free_netdev;
+		goto out_release_mem_region;
 
 	dio_set_drvdata(d, dev);
 	return 0;
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/