Re: [PATCH 1/2] - net/socket.c::sys_bind() cleanup.

[Jesper Juhl]

On Tue, 16 Nov 2004, Luiz Fernando N. Capitulino wrote:

> 
>  Hi,
> 
>  net/socket.c::sys_bind() is a bit complex function, the patch
> bellow makes it more clear.
> 
>  Note that the code does the same thing, it only makes difference
> for the programmer.
> 
Not exactely : 


> -		if((err=move_addr_to_kernel(umyaddr,addrlen,address))>=0) {

> +	err = move_addr_to_kernel(umyaddr, addrlen, address);
> +	if (err)
> +		goto out_put;


The original tests for err >= 0, your replacement tests if err is != 0


--
Jesper Juhl

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/