Re: [PATCH] [Request for inclusion] Filesystem in Userspace

From: Jan Engelhardt
Date: Tue Nov 16 2004 - 07:32:24 EST


>> The have been
>> patches to get rid of the existing casts so please don't introduce new
>> ones.
>
>I vote for explicit casts, makes code more readable.

And makes it more error prone. Once upon a time, a user wrote:

ptr = (int *)malloc(...)

And justified the use of the cast because gcc generated a warning, and I
replied that if he'd included <stdlib.h> (yeah, user space), the warning would
be gone, even without a cast. Sigh.



Jan Engelhardt
--
Gesellschaft für Wissenschaftliche Datenverarbeitung
Am Fassberg, 37077 Göttingen, www.gwdg.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/