Re: [PATCH] [Request for inclusion] Filesystem in Userspace

[Pekka Enberg]

Hi,

On Tue, 16 Nov 2004 11:20:22 +0100, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> >    - Breaks if CONFIG_PROC_FS is not enabled.
> 
> Yes.  Would a device node be better?  Perhaps.  This way there's no
> need to allocate a major/minor for a device.

...or fix your Kconfig to select procfs. :)

On Tue, 16 Nov 2004 11:20:22 +0100, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: 
> >    - Explicit casts are not needed when converting void pointers
> > (found in various places).
> 
> But they don't hurt either.  At least I can be sure to assign the
> right kind of pointer.

Hmm? The conversion is guaranteed by the standard which makes them
redundant. And redundancy does hurt maintainability. The have been
patches to get rid of the existing casts so please don't introduce new
ones.

                             Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/