Re: shmem_file_setup not exported

From: Måns Rullgård
Date: Sat Nov 06 2004 - 14:57:57 EST


Hugh Dickins <hugh@xxxxxxxxxxx> writes:

> On Sat, 6 Nov 2004, Måns Rullgård wrote:
>> I noticed this change in mm/shmem.c:
>>
>> -EXPORT_SYMBOL(shmem_file_setup);
>>
>> Is there a reason for this, other than nobody using it?
>
> That's the reason hch rightly removed the export, yes.
> ipc/shm.c does use it, but it's never a module, so doesn't need export.
> No other reason, beyond that it's appropriate to minimize exports.
> If you want to use it from your module, just patch the export back.

That makes using the module more complicated. I don't really care
much, I'm not actively using the module. I was just wondering whether
using it was incredibly silly for some reason.

--
Måns Rullgård
mru@xxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/