On Fri, Nov 05, 2004 at 09:10:08PM -0500, Len Brown wrote:
On Fri, 2004-11-05 at 16:50, Adrian Bunk wrote:
The patch below completely removes 7 functions that were
EXPORT_SYMBOL'ed but had exactly zero users in the kernel and makes
another one that was previously EXPORT_SYMBOL'ed static.
It also removes another unused global function to completely remove
drivers/acpi/hardware/hwtimer.c which contained no function used
anywhere in the kernel.
Please comment on whether this patch is correct or whether in-kernel
users of these functions are pending.
diffstat output:
drivers/acpi/acpi_ksyms.c | 8 -
drivers/acpi/events/evxfevnt.c | 191 -----------------------------
drivers/acpi/hardware/Makefile | 2
drivers/acpi/hardware/hwtimer.c | 200
-------------------------------
drivers/acpi/resources/rsxface.c | 52 --------
drivers/acpi/scan.c | 6
drivers/acpi/utilities/utxface.c | 89 -------------
include/acpi/achware.h | 17 --
include/acpi/acpi_bus.h | 1
include/acpi/acpixf.h | 24 ---
10 files changed, 6 insertions(+), 584 deletions(-)
No, I can't apply this one as-is.
Some of these routines are not called now
simply because Linux/ACPI is evolving and we don't
yet take advantage of some of the things supported
by ACPICA core we use.
I understand this, that's why I asked for comments on this patch.
But it seems a bit strange for me that e.g. the file hwtimer.c was added nearly three years ago and exports functions - but currently has exactly zero users. One effect is a needless code bloat for every single user with CONFIG_ACPI_INTERPRETER=y.
Removing unused global functions is a pretty cheap way to get the kernel smaller without any loss of functionality. Please check which of the functions touched in my patch will actually be used in the foreseeable future (if it would e.g. take another three years until hwtimer.c will be used, it might be better to re-add it when it will actually be used).
BTW: ACPI has tons of other unused global functions.