Re: [PATCH 2/3] WIN_* -> ATA_CMD_* conversion: update WIN_* users to use ATA_CMD_*

From: Ross Biro
Date: Sat Nov 06 2004 - 09:56:18 EST


On Fri, 5 Nov 2004 19:55:22 -0800, Chris Wedgwood <cw@xxxxxxxx> wrote:
> I assume for Windows they do that for all drives? Even older ones?

Most likely, but that doesn't imply that Windows XP works with ancient
ata drives.

>
> I also wonder what happens with TCQ when you get an error? Do you
> just retry everything outstanding?

My guess is yes, but I'll also bet the drive vendors have not tested
this path well.

> It probably should get fixed, there just doesn't seem to be much
> incentive to beat on the old IDE code though :( Minor cleanups seem
> worthwhile but anything intrusive I worry will break some hard-to-test
> platform for someone.

The best solution is probably to make it user selectable for now. I
know we need the reset/set features, or any sort of error causes a
major melt down. We can default to the current behaviour, so it
shouldn't break anything.

I'll make sure some patches for this are created sometime in the next
couple of months. I'll even try to make sure TCQ gets tested with
them if TCQ works well enough with the current code.

Ross

Ross
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/