Re: [PATCH]add an ifdef in sched.c

From: Ingo Molnar
Date: Fri Nov 05 2004 - 07:07:20 EST



* andyliu <liudeyan@xxxxxxxxx> wrote:

> -#define for_each_domain(cpu, domain) \
> +#ifdef CONFIG_SMP
> +# define for_each_domain(cpu, domain) \
> for (domain = cpu_rq(cpu)->sd; domain; domain = domain->parent)
> +#endif

why? A macro hanging around does not cause any bigger code - and the
#ifdef certainly makes the code less readable.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/