Re: [PATCH RESEND] pcmcia network drivers cleanup

[Jeff Garzik]

Stelian Pop wrote:
> Hi,
>
> The attached patch:
>   * cleans up the parameter passing (module_param() instead of MODULE_PARM()
>   * makes debugging work (PCMCIA_DEBUG does not exist anymore, make the
>     Makefile test for CONFIG_PCMCIA_DEBUG and activate DEBUG in CFLAGS)
>     and use the same debugging macros for every driver through code
>     reuse.

Comments:

1) Can you please separate module_param() and PCMCIA_DEBUG patches?

2) why not use pr_debug()?

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/