Re: [BK PATCH] Fix ip_conntrack_amanda data corruption bug that breaksamanda dumps

[Patrick McHardy]

David S. Miller wrote:

> On Fri, 05 Nov 2004 00:53:22 +0100
> Patrick McHardy <kaber@xxxxxxxxx> wrote:
>
>  
>
> > Your observation and your patch were correct, thanks. It is supposed
> > to be just a copy, I missed that it wasn't anymore. While your patch
> > works too, and is even faster with non-linear skbs, I don't like the
> > idea of using the skb as a scratch-area, so I sent this patch to Dave
> > instead.
> >    
>
> His patch isn't correct, even making a temporary change to
> a shared SKB is illegal.  Things like tcpdump could see
> corrupt SKB contents if they look during that tiny window
> when the newline character has been changed to NULL by
> the amanda conntrack module.
>  

True, I'm stupid sometimes :)

Regards
Patrick

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/