Re: [patch] Real-Time Preemption, -RT-2.6.10-rc1-mm2-V0.7.7

[Ingo Molnar]

* Michael J. Cohen <mjc@xxxxxxx> wrote:

> Ingo
> 	Great timing! only 7 minutes after I posted my concession speech. ;)
> 
> Here you go:
> 
>   LD      .tmp_vmlinux1
> kernel/built-in.o(.text+0x1e57c): In function `___trace':
> : undefined reference to `irqs_disabled_flags'
> kernel/built-in.o(.text+0x1e797): In function `add_preempt_count':
> : undefined reference to `irqs_disabled_flags'
> make: *** [.tmp_vmlinux1] Error 1

the patch below should fix this - but i'd suggest to disable
LATENCY_TRACING, i had bad experience with x86_64 gcc & mcount. (it was
not possible to get a working -pg and -fno-omit-frame-pointers at once.)

	Ingo

--- linux/include/asm-x86_64/system.h.orig
+++ linux/include/asm-x86_64/system.h
@@ -316,11 +316,16 @@ static inline unsigned long __cmpxchg(vo
 /* used in the idle loop; sti takes one instruction cycle to complete */
 #define safe_halt()		__asm__ __volatile__("sti; hlt": : :"memory")
 
+#define irqs_disabled_flags(flags)	\
+({					\
+	!(flags & (1<<9));		\
+})
+
 #define irqs_disabled()			\
 ({					\
 	unsigned long flags;		\
 	local_save_flags(flags);	\
-	!(flags & (1<<9));		\
+	irqs_disabled_flags(flags);	\
 })
 
 /* For spinlocks etc */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/