Re: [PATCH] deprecate pci_module_init

From: Jeff Garzik
Date: Wed Nov 03 2004 - 14:21:07 EST


Chris Wedgwood wrote:
On Wed, Nov 03, 2004 at 12:46:40PM -0500, Jeff Garzik wrote:


Wrong. There are way too many __correct__ drivers to do this at
present.


i could claim the same is true of MODULE_PARM yet we spew
warning-galore there...

There is a 2.4 version of module_param().

The semantics of pci_module_init() versus pci_register_driver() are different across 2.4/2.6. If you deprecate pci_module_init(), you are breaking drivers which right now can be ported to 2.4 with a simple cp(1).

It's just downright silly to deprecate the API that is used most heavily in drivers.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/