Re: [PATCH 9/14] FRV: CONFIG_MMU fixes

[David Howells]

> > That won't work. The else-if clause has to be within the context of the
> > parent function in which it now resides.
> 
> but you can still have the body of the if clause a noop for !MMU

No, you can't. That else-if clause mustn't be there at all for !MMU. It'd be
too permissive on some nommu archs and wouldn't compile on others.

> > It might actually be better to make /proc/kcore conditional on CONFIG_MMU.
> 
> Yupp.  In fact I'm pretty sure it can't be selected for m68knommu currently.

I'll do that, and that renders the whole argument moot anyway.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/