Re: [PATCH 10/14] FRV: Make calibrate_delay() optional

[David Howells]

> Just doing a quick skim, the patch looks good. Making a whole new file
> for just one function is a bit heavy handed, but I don't feel that code
> needed to be in main.c

Doing it this way means that we can use the linker's handling of archive
libraries to decide whether to actually use this function or not.

> My only nit would be to save the tabs and switch the code from:

And then it'll be argued that I should switch it back... Different people have
different opinions on how this should be arranged (of course, they're wrong if
they don't agree with my opinion:-).

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/