Re: [linux-pm] Adapt drivers to type-safe pci

From: Benjamin Herrenschmidt
Date: Mon Nov 01 2004 - 21:44:20 EST


On Mon, 2004-11-01 at 18:00 -0700, David Brownell wrote:
> On Monday 01 November 2004 12:26, Pavel Machek wrote:
> > Hi!
> >
> > This adapts few drivers to type-safe pci powermanagment. I introduced
> > device_to_pci_state helper that will be usefull to few drivers... Does
> > it look okay?
>
> I'd rather have something like the attached patch.
> Fixed policy mappings are generically broken; what
> about devices that don't support PCI_D2?
>
> This should I guess use the new "pci_power_t", but
> I'm not that current yet.

Your snipped (please, inline, don't attach) would mean D2 is to be
preferred over D3 at all times ?

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/