Re: [PATCH 475] HP300 LANCE

[Jeff Garzik]

Herbert Xu wrote:
> Andrew Morton <akpm@xxxxxxxx> wrote:
>
> > Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
> >
> > > On Sun, Oct 31, 2004 at 02:48:40AM -0800, Andrew Morton wrote:
> > > > > -        void *va = dio_scodetoviraddr(scode);
> > > > > +        unsigned long pa = dio_scodetophysaddr(scode);
> > > > > +        unsigned long va = (pa + DIO_VIRADDRBASE);
> > >
> > > Did you see the above quoted patch chunk?  The patch is inconsistent
> > > with _itself_, adding 'pa' and 'va' with different idents (but when they
> > > should be at the same identation level).
> >
> > Trust me ;)
>
>
> What Jeff means is that the patch is using a tab for pa and 8 spaces
> for va.


Precisely.  That's what my entire "whitespace challenged" comment meant.

When the patch adds two lines at the same visual indentation level in 
the source, but appear different in the patch, that is a signal that 
some tabs got accidentally converted to spaces somewhere.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/