Re: [PATCH] Add panic blinking to 2.6

[Chris Wedgwood]

On Sun, Oct 31, 2004 at 02:36:49AM +0100, Andi Kleen wrote:

> This patch readds the panic blinking that was in 2.4
> to 2.6.

cool

> +static int blink_frequency = 500;
> +module_param_named(panicblink, blink_frequency, int, 0600);

does it reall need to be a module? 

> +/* Returns how long it waited in ms */
> +long (*panic_blink)(long time) = no_blink;
> +EXPORT_SYMBOL(panic_blink);

i dont know we can't have this unconditionally with the 500ms period
(always present and on)

would that really harm anything?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/