Re: [patch] 2.6.10-rc1: SCSI aacraid warning

[Mark Haverkamp]

On Fri, 2004-10-29 at 16:37 +0200, Adrian Bunk wrote:
> On Fri, Oct 22, 2004 at 03:05:13PM -0700, Linus Torvalds wrote:
> >...
> > Summary of changes from v2.6.9 to v2.6.10-rc1
> > ============================================
> >...
> > Mark Haverkamp:
> >...
> >   o aacraid: dynamic dev update
> >...
> 
> 
> This causes the following warning with a recent gcc:
> 
> <--  snip  -->
> 
> ...
>   CC      drivers/scsi/aacraid/aachba.o
> drivers/scsi/aacraid/aachba.c: In function `aac_scsi_cmd':
> drivers/scsi/aacraid/aachba.c:1140: warning: integer constant is too large for "long" type
> ...
> 
> <--  snip  -->
> 
> 
> The fix is simple:
> 
> 
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> 
> --- linux-2.6.10-rc1-mm2-full/drivers/scsi/aacraid/aachba.c.old	2004-10-29 16:16:52.000000000 +0200
> +++ linux-2.6.10-rc1-mm2-full/drivers/scsi/aacraid/aachba.c	2004-10-29 16:22:14.000000000 +0200
> @@ -1137,7 +1137,7 @@
>  		char *cp;
>  
>  		dprintk((KERN_DEBUG "READ CAPACITY command.\n"));
> -		if (fsa_dev_ptr[cid].size <= 0x100000000)
> +		if (fsa_dev_ptr[cid].size <= 0x100000000ULL)
>  			capacity = fsa_dev_ptr[cid].size - 1;
>  		else
>  			capacity = (u32)-1;

Sorry about that, I have it fixed in my working version.  I must have
forgotten to add it to the patch.


-- 
Mark Haverkamp <markh@xxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/