Re: [RFC] Rename SECTOR_SIZE to IDE_SECTOR_SIZE

[Jens Axboe]

On Tue, Oct 26 2004, Chris Wedgwood wrote:
> On Wed, Oct 27, 2004 at 02:47:51AM -0400, Jeff Garzik wrote:
> 
> > It's highly silly to rename the same name + the same value to
> > multiple different names.
> 
> initially i was going to do that, but when i looked at the code i
> realized the problem is some of the users seem to be semantically
> different and potentially might want to be changed separate to the
> others
> 
> > Put it in a common header somewhere, and only rename the oddballs
> > (if any).
> 
> we could have UNIX_SECTOR_SIZE in blkdev.h but as i said, some users
> really are 512 for different reasons that might change (?)

Please, just call it IO_SECTOR_SIZE or BIO_SECTOR_SIZE to signify that
it's the block io sector size. And use that where it applies, leave the
rest of the unrelated cases alone.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/