Re: Compile breakage from me

From: Jeff Garzik
Date: Mon Oct 25 2004 - 16:02:26 EST


Linus Torvalds wrote:

On Mon, 25 Oct 2004, Linus Torvalds wrote:

How about just sending me the for_each_pci_dev() macro instead?


Never mind. I just picked it up directly from my kernel mailing list
archives instead - Hanna had already signed off on it.

hmmmm, so where do the 'gotten' references go?


--- a/drivers/char/hw_random.c 2004-10-25 16:18:50 -04:00
+++ b/drivers/char/hw_random.c 2004-10-25 16:18:50 -04:00
@@ -581,7 +581,7 @@
DPRINTK ("ENTER\n");
/* Probe for Intel, AMD RNGs */
- while ((pdev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL) {
+ for_each_pci_dev(pdev) {


+#define for_each_pci_dev(d) while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)


Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/