Re: janitoring printk with no KERN_ constants, kill all defaults?

[Chuck Ebbert]

Dave Jones wrote:

> Consider this..
>
>       printk (KERN_INFO "blah blah ");
>       if (foo)
>               printk ("%s", stringptr);
>       else
>               printk ("%d", number);
>       printk ("\n");
>
> There's nothing wrong with any of those printk's, so you
> cannot do the checks you mention above.

  But other code can call printk in between on SMP and/or preempt systems,
making a mess of the log.  This is a(n old) problem that should be
fixed once and for all, AFAIC.



--Chuck Ebbert  15-Oct-04  13:05:20
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/