Re: [PATCH 2.6.9-rc3-mm2] [m32r] SIO driver for m32r

From: Rusty Russell
Date: Thu Oct 14 2004 - 20:28:50 EST


On Wed, 2004-10-06 at 16:19, Hirokazu Takata wrote:
> Hello,
>
> Here is a patch to support the M32R SIO (serial IO) driver.
> Please apply.

> +MODULE_PARM(share_irqs_sio, "i");

Hi Hirokazu!

Please use the modern "module_param(share_irqs_sio, bool, 0400)" here
(I assume you don't want this parameter to be writable, hence the 0400
permissions). MODULE_PARM is deprecated.

Thankyou!
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/