Re: cciss update [2/2] fixes for Steeleye Lifekeeper

From: James Bottomley
Date: Thu Oct 14 2004 - 09:48:48 EST


On Thu, 2004-10-14 at 03:39, Christoph Hellwig wrote:
> No, this is bogus. Never call add_disk on a volume that hasn't been
> configured and full set up. If you need to talk to our driver without
> online volumes add a character device.

I don't think so ... it's a volume you know exists but you can't get
access to (in a shared storage configuration). In SCSI we have two
examples of this now:

1. The case where the device responds to inquiry but errors read
capacity (usually because of a reservation conflict). Here we configure
a totally bogus 1GB volume with 512 byte sectors.

2. The case where the device has an illegal sector size. Here we
configure a zero size volume.

In both cases we expose the device in sd but make it effectively
inaccessible because we want to be able to send ioctls to it but not
allow ordinary read/writes. (Although I'd really like not to configure
a bogus size in case 1.). I don't see how the cciss case is any
different from this.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/