Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3

[Jeff Garzik]

On Tue, Oct 12, 2004 at 01:00:53PM -0400, Mark Lord wrote:
> James Bottomley wrote:
> >On Fri, 2004-10-08 at 10:34, Mark Lord wrote:
> >
> >>If those locks are not needed, the scsi.c maintainer really should
> >>nuke'em.
> >
> >I think you can safely assume he has more important things to do.
> 
> I was actually working on the assumption that the lock might be
> there because it is/was necessary for something, like perhaps protecting
> access to the add_timer()/del_timer() calls associated with the scmd?
> 
> If not, no issue -- it can be removed from the driver.


I'll respectfully disagree with James...  I think the most prudent
course of action is to follow the example of SCSI common code.

If the SCSI core is doing something wrong, we should fix that _first_,
not set a precedent of confusing dissociation.

Everyone knows that Linux programmers engineer with their cut-n-paste
feature.

	Jeff




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/