Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h

From: Jan Dittmer
Date: Mon Oct 11 2004 - 07:32:37 EST


Cal Peake wrote:
On Mon, 11 Oct 2004, Jan Dittmer wrote:


Cal Peake wrote:


inw((hw)->iobase + ( (off) << (hw)->reg_spacing )) : \
- readw((hw)->iobase + ( (off) << (hw)->reg_spacing )))
+ readw((void __iomem *)(hw)->iobase + ( (off) << (hw)->reg_spacing )))
#define hermes_write_reg(hw, off, val) do { \

Isn't the correct fix to declare iobase as (void __iomem *) ?


iobase is an unsigned long, declaring it as a void pointer is prolly not what we want to do here. The typecast seems proper. A lot of other drivers do this as well thus it must be proper ;-)

Why is iobase a unsigned long in the first place? Isn't this broken for 64bit archs?

Thanks,

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/