Re: [KJ] [RFT 2.6] pci-gart.c replace pci_find_device with pci_get_device

From: Matthew Wilcox
Date: Sat Oct 09 2004 - 13:20:45 EST


On Sat, Oct 09, 2004 at 10:15:34AM -0700, Scott Feldman wrote:
> On Fri, 2004-10-08 at 15:55, Hanna Linder wrote:
> > @@ -81,7 +81,7 @@ static u32 gart_unmapped_entry;
> >
> > #define for_all_nb(dev) \
> > dev = NULL; \
> > - while ((dev = pci_find_device(PCI_VENDOR_ID_AMD, 0x1103, dev))!=NULL)\
> > + while ((dev = pci_get_device(PCI_VENDOR_ID_AMD, 0x1103, dev))!=NULL)\
> > if (dev->bus->number == 0 && \
> > (PCI_SLOT(dev->devfn) >= 24) && (PCI_SLOT(dev->devfn) <= 31))
>
> for_each_pci_dev?

for_each_pci_dev() doesn't take a VENDOR/DEVICE ID pair.
I think this is a mistake.

--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/