Re: [PATCH] make automounter runnable in foreground and add stderrlogging

From: raven
Date: Fri Oct 08 2004 - 21:39:03 EST


On Thu, 7 Oct 2004 Valdis.Kletnieks@xxxxxx wrote:

> On Thu, 07 Oct 2004 20:49:17 +0300, Denis Vlasenko said:
>
> > PS: is there a reason why automount does this?
> >
> > /* include/config.h. Generated by configure. */
> > #define PATH_MOUNT "/usr/bin/mount"
> > #define PATH_UMOUNT "/usr/bin/umount"
> > #define PATH_E2FSCK "/usr/bin/fsck.ext2"
> > #define PATH_E3FSCK "/usr/bin/fsck.ext3"
> >
> > We have $PATH for ages...
>
> Yes, and sometimes you specifically want to make sure you pick up the
> right official binary, and not some other one that happens to be in $PATH.
> If somebody manages to get automount launched with an insecure $PATH, you
> could end up invoking a trojaned mount command (remember why "." in $PATH
> is a security issue....)
>

And that would be the point of using configure to find this path info.
rather than using $PATH.

Ian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/