Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3

[Mark Lord]

James Bottomley wrote:
> On Fri, 2004-10-08 at 10:15, Mark Lord wrote:
>
> > > Actually, the driver has no need for a thread at all.  Since you're
> > > simply using it to fire hotplug events, use schedule_work instead.
> >
> > That worries me some, because the mid-layer will perform blocking I/O
> > and the like, and I'm not sure how much that stuff may depend on its
> > own usage (any?) of workqueues.  If you believe it to be safe,
> > then I'll nuke the kthread entirely.
>
>
> We use this already for other entities that require user context like
> domain validation.  It seems to work as advertised.

Can deadlock occur here, since qstor.c is already using schedule_work()
as part of it's internal bottom-half handling for abnormal conditions?

Eg.  hotplug event -> schedule_work -> mid-layer -> queuecommand
      --> sleep  :: interrupt -> schedule_work -> deadlock?

Just checking.. we all want this to function well.
--
Mark Lord
(hdparm keeper & the original "Linux IDE Guy")
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/